Review apps: make apps' root filesystems readonly#1439
Conversation
In production they will have readonly root filesystems. Making them readonly in review will allow us to catch places where that causes a problem earlier on.
… one In production we run "db:migrate" on its own, and it has some specific file-writing behaviours that "db:setup" doesn't.
AWS ECS docs [1] say that a file that exists in a directory that is subsequently marked as a volume will be copied to the host and remounted into the container. This is necessary for us to do with the "db/" directory because the "db:migrate" Rake task writes to "db/schema.rb" [1] https://docs.aws.amazon.com/AmazonECS/latest/developerguide/bind-mounts.html
AP-Hunt
force-pushed
the
review_apps_root_fs_ro
branch
from
3fa69e0 to
0bff082
Compare
|
|
🎉 A review copy of this PR has been deployed! It is made of up two components Important Not all of the functionality of forms-runner is present in review apps. You should use the full dev environment to test the functionality which is disabled here. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
2 participants
What problem does this pull request solve?
In production they will have readonly root filesystems. Making them readonly in review will allow us to catch places where that causes a problem earlier on.
Things to consider when reviewing